introduce gRPC logging support #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
force-pushed
the
grpc-logging
branch
from
3bd0ffa
to
f2e67e9
Compare
dwsupplee
force-pushed
the
grpc-logging
branch
from
f2e67e9
to
75014af
Compare
jdpedrie
reviewed
Oct 24, 2016
| * @param array $keys | ||
| * @return array | ||
| */ | ||
| private function filterArgs(&$args, $keys) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -49,7 +49,7 @@ | |||
| * ``` | |||
| * | |||
| * Please take care in installing the same version of these libraries that are | |||
| * outlined in the project's composer.json suggest keyword. | |||
| * outlined in the project's composer.json require-dev keyword. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
force-pushed
the
grpc-logging
branch
from
1d8493e
to
c448baa
Compare
jdpedrie
reviewed
Oct 24, 2016
| * @param string $keys | ||
| * @param array $arr | ||
| * @return string | ||
| * @throws \InvalidArgumentException |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -134,11 +143,11 @@ private function handleResponse($response) | |||
| if ($response instanceof PagedListResponse) { | |||
| return $response->getPage() | |||
| ->getResponseObject() | |||
| ->serialize(new PhpArray()); | |||
| ->serialize($this->codec); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.